update deno_npm with packument changes#209
Merged
nathanwhit merged 1 commit intodenoland:mainfrom Apr 3, 2025
Merged
Conversation
|
|
There was a problem hiding this comment.
Pull Request Overview
This PR updates the npm packument handling in the code and bumps the version of the deno_npm dependency to align with upstream changes.
- Introduces new fields (extra, is_deprecated, has_bin, has_scripts, optional_peer_dependencies) in npm metadata structures.
- Removes the outdated fields (bin, scripts, deprecated) from the packument handling code.
- Updates Cargo.toml to use deno_npm version "0.31.0" in place of "0.27.2".
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/v2.rs | Modifies npm metadata structure to adopt new packument fields. |
| Cargo.toml | Bumps the deno_npm version to match packument format changes. |
Comments suppressed due to low confidence (2)
src/v2.rs:1795
- Since the npm packument structure has been updated, please ensure that all existing code interacting with npm metadata is revised to handle the new fields and the removal of the old ones.
extra: Default::default(),
Cargo.toml:54
- The deno_npm version update may introduce breaking changes; please verify that all updated code is compatible with the new version and that relevant documentation is updated accordingly.
deno_npm = { version = "0.31.0" }
marvinhagemeister
approved these changes
Apr 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.